sahnib commented on code in PR #45376:
URL: https://github.com/apache/spark/pull/45376#discussion_r1576435733
##########
sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala:
##########
@@ -676,6 +678,43 @@ class KeyValueGroupedDataset[K, V] private[sql](
)
}
+ private[sql] def transformWithState[U: Encoder](
+ statefulProcessor: StatefulProcessor[K, V, U],
+ timeoutMode: TimeoutMode,
+ eventTimeColumnName: String,
+ outputMode: OutputMode): Dataset[U] = {
+ val existingWatermarkDelay = logicalPlan.flatMap {
+ case EventTimeWatermark(_, delay, _) => Seq(delay)
+ case _ => Seq()
+ }
+
+ if (existingWatermarkDelay.isEmpty) {
+ throw QueryCompilationErrors.cannotAssignEventTimeColumn()
+ }
+
+ val transformWithState = TransformWithState[K, V, U](
+ groupingAttributes,
+ dataAttributes,
+ statefulProcessor,
+ timeoutMode,
+ outputMode,
+ child = logicalPlan
+ )
+
+ val twsDS = Dataset[U](
+ sparkSession,
+ transformWithState
+ )
+
+ val delay = existingWatermarkDelay.head
+
+ Dataset[U](sparkSession, EliminateEventTimeWatermark(
+ UpdateEventTimeWatermarkColumn(
+ UnresolvedAttribute(eventTimeColumnName),
Review Comment:
The Analyzer performs a check on all expressions to ensure there are no
unresolved attributes. I verified this with a simple test which provides a
eventTimeColumn that is not present and it fails with the error
```
org.apache.spark.sql.catalyst.ExtendedAnalysisException:
[UNRESOLVED_COLUMN.WITH_SUGGESTION] A column, variable, or function parameter
with name `missingEventTimeColum
n` cannot be resolved. Did you mean one of the following?
[`outputEventTime`, `count`, `key`]. SQLSTATE: 42703;
```
I have added a unit test case for this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
