srielau commented on code in PR #46138:
URL: https://github.com/apache/spark/pull/46138#discussion_r1575173778
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -365,6 +367,8 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper with Logging {
val cols =
Option(ctx.identifierList()).map(visitIdentifierList).getOrElse(Nil)
val partitionKeys =
Option(ctx.partitionSpec).map(visitPartitionSpec).getOrElse(Map.empty)
+ blockBang(ctx.errorCapturingNot())
Review Comment:
I don't see how that helps. We don't have context to tell us whether it's a
legal or illegal usage of `!`.
This is the best I could come up with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
