panbingkun commented on code in PR #46130:
URL: https://github.com/apache/spark/pull/46130#discussion_r1574616185
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:
##########
@@ -1225,7 +1231,8 @@ private[spark] class Client(
if (log.isDebugEnabled) {
logDebug(formatReportDetails(report, getDriverLogsLink(report)))
} else if (lastState != state) {
- logInfo(formatReportDetails(report, getDriverLogsLink(report)))
+ logInfo(log"${MDC(LogKey.REPORT_DETAILS,
Review Comment:
I am not sure if it is necessary to expand all variables in
`ormatReportDetails(report, getDriverLogsLink(report))`, or is it acceptable in
its current form?
https://github.com/apache/spark/blob/61dc9d991373c01d449a8ed26d9bfd7eb93f9301/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala#L1307-L1326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
