harshmotw-db commented on code in PR #46011:
URL: https://github.com/apache/spark/pull/46011#discussion_r1562187601
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/variant/VariantExpressionEvalUtilsSuite.scala:
##########
@@ -122,4 +122,42 @@ class VariantExpressionEvalUtilsSuite extends
SparkFunSuite {
Map("sizeLimit" -> "16.0 MiB", "functionName" -> "`parse_json`"))
}
}
+
+ test("isVariantNull") {
Review Comment:
I added tests where you can see how it behaves when integrated with other
variant expressions, namely `parse_json` and `variant_get`.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/variant/VariantExpressionEvalUtilsSuite.scala:
##########
@@ -122,4 +122,42 @@ class VariantExpressionEvalUtilsSuite extends
SparkFunSuite {
Map("sizeLimit" -> "16.0 MiB", "functionName" -> "`parse_json`"))
}
}
+
+ test("isVariantNull") {
Review Comment:
I just added tests where you can see how it behaves when integrated with
other variant expressions, namely `parse_json` and `variant_get`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
