mridulm commented on code in PR #45367:
URL: https://github.com/apache/spark/pull/45367#discussion_r1561552345
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -1014,6 +1014,15 @@ package object config {
.timeConf(TimeUnit.NANOSECONDS)
.createWithDefaultString("1s")
+ private[spark] val
LISTENER_BUS_EVENT_QUEUE_WAIT_FOR_EVENT_DISPATCH_EXIT_ON_STOP =
+
ConfigBuilder("spark.scheduler.listenerbus.eventqueue.waitForEventDispatchExitOnStop")
+ .doc("Whether wait until the dispatch thread exit when stop invoked. " +
+ "This is set to true by default for graceful shutdown of the event
queue, " +
+ "but allow user to configure the behavior if they don't need.")
+ .version("4.0.0")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
To clarify, I am suggesting to use int to represent a boolean.
Rather, use it to set the wait time - where `0`, the default value, will
mean wait until stopped - which preserves the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
