mihailom-db opened a new pull request, #46004: URL: https://github.com/apache/spark/pull/46004
### What changes were proposed in this pull request? INDETERMINATE_COLLATION should only be thrown on comparison operations and memory storing of data, and we should be able to combine different implicit collations for certain operations like concat and possible others in the future. This is why we have to add another predefined collation id named INDETERMINATE_COLLATION_ID which means that the result is a combination of conflicting non-default implicit collations. Right now it would an id of -1 so it fail if it ever goes to the CollatorFactory. ### Why are the changes needed? Support for concatenation between columns of different collation is what `PGSQL` follows and this behaviour should be followed. ### Does this PR introduce _any_ user-facing change? Yes. It adds new error of indeterminate collation. ### How was this patch tested? Tests in CollationSuite. ### Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
