mihailom-db commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1556979888
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/StringTypeCollated.scala:
##########
@@ -52,3 +52,20 @@ case object StringTypeAnyCollation extends
StringTypeCollated {
override private[sql] def simpleString: String = "string_any_collation"
override private[sql] def acceptsType(other: DataType): Boolean =
other.isInstanceOf[StringType]
}
+
+/**
+ * Use ArrayType(StringTypeCollated) for expressions supporting different type
of
+ * collations in ArrayTypes
+ */
+case class AbstractArrayType(elementType: StringTypeCollated) extends
AbstractDataType {
Review Comment:
Done, I also realised, should I move the StringTypeCollated to the right
package? It is now in catalyst.expressions instead of types as all other types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
