Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/5808#issuecomment-97923681
Do you think it will be clear enough if we still keep the default value at
1 and explains this means 2 tries maximum?
Or should we change the default value or the code or the name of the conf?
On 30 Apr 2015 8:23 pm, "Cody Koeninger" <[email protected]> wrote:
> Yknow, I just looked at the code for other reasons, and it is the number
> of retries, not tries (so the default setting of 1 means a max of 2
> consecutive attempts). Sorry for being spacey earlier in the jira ticket.
>
> val o = kc.getLatestLeaderOffsets(currentOffsets.keySet)
> if (o.isLeft) {
> val err = o.left.get.toString
> if (retries <= 0) {
> throw new SparkException(err)
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/5808#issuecomment-97907134>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
