Github user tmyklebu commented on a diff in the pull request:
https://github.com/apache/spark/pull/593#discussion_r12195265
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -163,14 +165,27 @@ class ALS private (
def run(ratings: RDD[Rating]): MatrixFactorizationModel = {
val sc = ratings.context
- val numBlocks = if (this.numBlocks == -1) {
- math.max(sc.defaultParallelism, ratings.partitions.size / 2)
+ val numUserBlocks = if (this.numUserBlocks == -1) {
--- End diff --
@mengxr It's error-prone to reuse the name `numBlocks`, too, but that
didn't stop the previous author. I can remove the shadowing problem everywhere
if you prefer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
