Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5477#discussion_r28202475
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala ---
    @@ -290,10 +290,19 @@ class ExecutorRunnable(
           YarnSparkHadoopUtil.setEnvFromInputString(env, userEnvs)
         }
     
    +    // lookup appropriate http scheme for container log urls
    +    val yarnHttpPolicy = yarnConf.get(
    +      YarnConfiguration.YARN_HTTP_POLICY_KEY,
    --- End diff --
    
    Do you happen to know when these two fields were added to 
`YarnConfiguration`? Just want to make sure this isn't introducing an 
incompatibility with old versions. That said I see this in at least 2.2.0 so 
probably fine. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to