Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5249#discussion_r27500087
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -106,7 +118,6 @@ class LogisticRegressionModel (
// If dataMatrix and weightMatrix have the same dimension, it's binary
logistic regression.
if (numClasses == 2) {
- require(numFeatures == weightMatrix.size)
--- End diff --
I think the check at
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala#L52
is before the check at here.
So if ```numFeatures == weightMatrix.size``` is not satisfied, the model
will created failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
