Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4904#discussion_r27157383
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1053,10 +1053,19 @@ class SQLQuerySuite extends QueryTest with
BeforeAndAfterAll {
test("SPARK-6145: ORDER BY test for nested fields") {
jsonRDD(sparkContext.makeRDD(
"""{"a": {"b": 1, "a": {"a": 1}}, "c": [{"d": 1}]}""" ::
Nil)).registerTempTable("nestedOrder")
- // These should be successfully analyzed
- sql("SELECT 1 FROM nestedOrder ORDER BY a.b").queryExecution.analyzed
- sql("SELECT a.b FROM nestedOrder ORDER BY a.b").queryExecution.analyzed
- sql("SELECT 1 FROM nestedOrder ORDER BY a.a.a").queryExecution.analyzed
- sql("SELECT 1 FROM nestedOrder ORDER BY
c[0].d").queryExecution.analyzed
+
+ checkAnswer(sql("SELECT 1 FROM nestedOrder ORDER BY a.b"), Row(1))
+ checkAnswer(sql("SELECT a.b FROM nestedOrder ORDER BY a.b"), Row(1))
+ checkAnswer(sql("SELECT 1 FROM nestedOrder ORDER BY a.a.a"), Row(1))
+ checkAnswer(sql("SELECT a.a.a FROM nestedOrder ORDER BY a.a.a"),
Row(1))
+ checkAnswer(sql("SELECT 1 FROM nestedOrder ORDER BY c[0].d"), Row(1))
+ checkAnswer(sql("SELECT c[0].d FROM nestedOrder ORDER BY c[0].d"),
Row(1))
--- End diff --
Please ignore the above comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
