Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4940#discussion_r26011394
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -84,9 +84,15 @@ object GenerateProjection extends
CodeGenerator[Seq[Expression], Projection] {
val elementName = newTermName(s"c$i")
val iLit = ru.Literal(Constant(i))
- q"if(i == $ordinal) { if(isNullAt($i)) return null else return
$elementName }"
+ q"if(i == $ordinal) { return $elementName }"
}
- q"override def apply(i: Int): Any = { ..$cases; $accessorFailure }"
+ q"""
+ override def apply(i: Int): Any = {
+ if (i < 0 || i >= this.length) $accessorFailure
--- End diff --
Will that be the same checking with `if(i == $ordinal)`? and in `..$cases`,
it will run the checking again, which seems not necessary to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
