----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75182/#review226869 -----------------------------------------------------------
Fix it, then Ship it! We should also test the discard happens on watcher destruction. 3rdparty/libprocess/src/posix/io.cpp Lines 223-224 (patched) <https://reviews.apache.org/r/75182/#comment315160> these need to be synchronized - Benjamin Mahler On Aug. 20, 2024, 9:28 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75182/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2024, 9:28 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Adds basic watcher class for filesystem watch notifications. We > currently only support Linux with inotify. > > We currently support inotify events for writing, deleting, and renaming > a file. We do not support watching directories. > > Watchers may only be created with the create_watcher helper. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/io.hpp > 00519d4fcea1b740e5b6472894c16ee28ab0ecb4 > 3rdparty/libprocess/src/posix/io.cpp > 3862e3b9f5e0b43aa7cf30c753e24f02f935dd41 > 3rdparty/libprocess/src/tests/io_tests.cpp > c2bb36b180d9916a212e4eb79b33e9b1e1acff3e > > > Diff: https://reviews.apache.org/r/75182/diff/1/ > > > Testing > ------- > > Watcher tests added under IOTest. Tests consistently pass with > --gtest_repeat=-1 --gtest_break_on_failure flag. > > > Thanks, > > Jason Zhou > >
