----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75181/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- Currently we only wait until a cgroup's pids (retrieved from cgroup.procs) is empty. However even if a cgroup's pids are empty the rmdir call on it may still return EBUSY, causing us to fail the destroy operation. We want to retry the rmdir operation even on EBUSY for up to 5 seconds to ensure that we are able to delete the cgroup. This approach is similar to how crun is destroying its cgroups. see: https://github.com/containers/crun/blob/10b3038c1398b7db20b1826f94e9d4cb444e9568/src/libcrun/cgroup-utils.c#L471 Diffs ----- src/linux/cgroups2.cpp 9dd100aa6d224d67166cc80473423ea5fa815c14 Diff: https://reviews.apache.org/r/75181/diff/1/ Testing ------- The test RemoveNonCheckpointingFramework was previously failing due to not being able to remove its cgroups. This test now passes Thanks, Jason Zhou
