----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75176/#review226858 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 15, 2024, 8:43 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75176/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2024, 8:43 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > In cgroups1, we returned a pending future for containers that shared > cgroups with their parents. > > In cgroups2, since we always create cgroups for our containers, we no > longer need to consider this special case. So we only return failure > if there is an unknown container. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > d1507ecd979405d1fd4d56c5fcd990b22eb311f6 > > > Diff: https://reviews.apache.org/r/75176/diff/2/ > > > Testing > ------- > > Compiles okay. When later patches are applied NamespacesIsolatorTest pass and > NestedMesosContainerizerTests pass (except for the ones that check for > subsystem hierarchies) > > > Thanks, > > Jason Zhou > >
