----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75175/#review226852 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 15, 2024, 8:29 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75175/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2024, 8:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > In cgroups1, if a container is sharing cgroups with its parents, we will > return the parent's status. > > In cgroups2, we want to mimic this behavior even though we always create > cgroups for our containers. Since we do not do anything with our > container's cgroup if isolate == false. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > d1507ecd979405d1fd4d56c5fcd990b22eb311f6 > > > Diff: https://reviews.apache.org/r/75175/diff/1/ > > > Testing > ------- > > Compiles okay. When later patches are applied NamespacesIsolatorTest pass and > NestedMesosContainerizerTests pass (except for the ones that check for > subsystem hierarchies) > > > Thanks, > > Jason Zhou > >
