----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75171/#review226847 -----------------------------------------------------------
Ship it! src/slave/containerizer/mesos/containerizer.cpp Lines 568-573 (original), 568-580 (patched) <https://reviews.apache.org/r/75171/#comment315143> hmm this is hard to wrap one's head around, perhaps we can more clearly capture when we need to force creation? - Benjamin Mahler On Aug. 15, 2024, 8:52 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75171/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2024, 8:52 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently we are not checking that the cgroups isolator is being used > with the linux launcher. We need to ensure that if the linux launcher > is being used, the cgroups isolator is also being used so that the > cgroups for the containers can be made inside the isolator's prepare(). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 48bc4bc8f7b72b6d6ce4c7ddae98cca7cfb290ee > > > Diff: https://reviews.apache.org/r/75171/diff/2/ > > > Testing > ------- > > Compiles okay. When later patches are applied NamespacesIsolatorTest pass and > NestedMesosContainerizerTests pass (except for the ones that check for > subsystem hierarchies) > > > Thanks, > > Jason Zhou > >
