----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75166/#review226837 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 13, 2024, 6:38 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75166/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2024, 6:38 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > To support nested containers with nested cgroups, we need to enable > controllers in cgroup.subtree_control file for the appropriate nested > cgroup. > > To do so, we need to ensure that the parents have the the requested > controller in their cgroup.subtree_control file so that the nested > cgroup can have the controller written into subtree_control as well. > Otherwise we will get a 'no such file or directory' error. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > c9162c4ad74225fc736e8dfc7f3d108c115c543b > > > Diff: https://reviews.apache.org/r/75166/diff/1/ > > > Testing > ------- > > With SupportNesting() returning true, ROOT_CGROUPS_RecoverNestedWithoutConfig > with an independent cgroup is able to pass, whereas before it fails with > '(launch).failure(): Failed to enable controller 'cpu' in cgroup > 'mesos_test/52240cb6-96ee-425d-a5dc-d34a6d0a51d0/mesos/f3039785-f2a0-430f-a5a5-35a884cd8168': > No such file or directory' > > > Thanks, > > Jason Zhou > >
