----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75162/#review226821 -----------------------------------------------------------
Isn't this going to miss things like perf_event? Seems like you instead want cgroups/all to run all the creator functions? - Benjamin Mahler On Aug. 9, 2024, 11:04 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75162/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2024, 11:04 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, we cannot use the cgroups/all flag to its corresponding > controllers in cgroups2. > The flag causes us to grabs all the values in the cgroup.controllers > file. And the memory controller is called 'memory' in the file, whereas > we named it 'mem' in our isolation flag. So we need a way to translate > the controller names to our names in the creators hashmap. > > This fix incidentally fixes the > ROOT_CGROUPS_AgentRecoveryWithNewCgroupSubsystems test as it was unable > to create the memory controller using cgroups/all flag. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > 4174be0fab3ef28740686eaf20bee5fb7ae4282a > > > Diff: https://reviews.apache.org/r/75162/diff/2/ > > > Testing > ------- > > ROOT_CGROUPS_AgentRecoveryWithNewCgroupSubsystems passes. > > > Thanks, > > Jason Zhou > >
