----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75160/#review226808 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 9, 2024, 7:19 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75160/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2024, 7:19 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently we are tokenizing the cgroup argument when we could be > directly operating on the string using our strings utility helpers > instead. > > This patch replaces the tokenizing logic to using the strings library. > > > Diffs > ----- > > src/slave/containerizer/mesos/paths.cpp > 444ee00200bff85a321adebc9f2548f02611857b > > > Diff: https://reviews.apache.org/r/75160/diff/1/ > > > Testing > ------- > > MesosContainerizerPathsTest still pass > > > Thanks, > > Jason Zhou > >
