-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75155/#review226797
-----------------------------------------------------------


Ship it!





src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp
Lines 87 (patched)
<https://reviews.apache.org/r/75155/#comment315106>

    we should also make "cgroups/blkio" in the `--isolation` flag work with 
this, for backwards compatibility
    
    this alisasing can be done in a different patch


- Benjamin Mahler


On Aug. 8, 2024, 8:20 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75155/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2024, 8:20 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the IoControllerProcess.
> This replaces the blkio controller from cgroups v1. 
> We currently only use it to helps us work with the cgroups/all isolation flag.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 50684b615d7fdec90990f5dafd5e12ed7ad3d10b 
>   src/Makefile.am 02b9115e5020974cbcae11c296b887311e50a553 
>   src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp 
> a027ee63290d89fd46871355ed2950b7456cc233 
>   src/slave/containerizer/mesos/isolators/cgroups2/constants.hpp 
> 5e642669465363578e3b689be855a7152291c00c 
>   src/slave/containerizer/mesos/isolators/cgroups2/controllers/io.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups2/controllers/io.cpp 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/75155/diff/1/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>

Reply via email to