----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75156/#review226795 -----------------------------------------------------------
src/slave/containerizer/mesos/paths.cpp Lines 681-683 (original), 681-683 (patched) <https://reviews.apache.org/r/75156/#comment315105> maybe we should document this, including some example inputs and outputs of interest? src/slave/containerizer/mesos/paths.cpp Lines 701-703 (patched) <https://reviews.apache.org/r/75156/#comment315104> hm.. this won't handle slashes in `root`? - Benjamin Mahler On Aug. 8, 2024, 8:06 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75156/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2024, 8:06 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, CgroupsIsolatorTest.ROOT_CGROUPS_PERF_PerfForward fails > during recovery because it cannot create the directory for the recovered > container. This happens because the original containerId, when > recovered, includes the cgroup root. The function that converts a cgroup > to a containerId does not ignore the cgroup root, even though we do not > expect it to be included. > > To fix this, we will remove the first token of the cgroup if it matches > the cgroup root. This will prevent attaching an extraneous cgroup root > to the containerId when parsing it from a cgroup. > > > Diffs > ----- > > src/slave/containerizer/mesos/paths.cpp > 1269502794b14fa3683afb984ac3ae226f9ac5d5 > > > Diff: https://reviews.apache.org/r/75156/diff/1/ > > > Testing > ------- > > ROOT_CGROUPS_PERF_PerfForward test now passes. > > > Thanks, > > Jason Zhou > >
