----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75148/#review226786 -----------------------------------------------------------
src/slave/containerizer/device_manager/device_manager.cpp Lines 263 (patched) <https://reviews.apache.org/r/75148/#comment315089> let's default to true and only pass false in the recovery case? - Benjamin Mahler On Aug. 7, 2024, 4:48 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75148/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2024, 4:48 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, commit_device_access_changes always checkpoints the > device manager state **and** configures the bpf programs for the cgroup > based on its device access state. > > We add an argument to commit_device_access_changes for the caller to > determine whether they want the state to be checkpointed along with > attaching the ebpf program > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.cpp > e613323dc47a7980984426d37b6fc5cfc52dffe0 > > > Diff: https://reviews.apache.org/r/75148/diff/2/ > > > Testing > ------- > > No functionality change in this patch. Compiles okay and all device manager > tests pass > > > Thanks, > > Jason Zhou > >
