----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75143/#review226778 -----------------------------------------------------------
src/slave/containerizer/device_manager/device_manager.cpp Line 233 (original), 266 (patched) <https://reviews.apache.org/r/75143/#comment315078> probably s/persist/checkpoint/ would be more clear - Benjamin Mahler On Aug. 6, 2024, 4:29 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75143/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2024, 4:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently we do not checkpoint the device access state of each cgroup > when the configure or reconfigure is called. Meaning that we have > no way of recovering a cgroup's device access state. > > We will checkpoint state of the device manager whenever its state > is being changed to ensure that we can recover the most recent state > when necessary. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.cpp > e613323dc47a7980984426d37b6fc5cfc52dffe0 > > > Diff: https://reviews.apache.org/r/75143/diff/2/ > > > Testing > ------- > > In later patches of the stack, we were able to ensure that the state was > persisted and was able to be recovered. > > > Thanks, > > Jason Zhou > >
