----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75137/#review226767 -----------------------------------------------------------
Ship it! src/slave/containerizer/device_manager/device_manager.hpp Lines 55-56 (patched) <https://reviews.apache.org/r/75137/#comment315040> maybe just ::create? or ::from? - Benjamin Mahler On Aug. 2, 2024, 2:34 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75137/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2024, 2:34 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > We currently have a wildcard conversion helper but it was only > available for use inside the device manager test file. > > This change pulls out the helper and makes it available as a static > function for use outside just tests. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.hpp > a987895d579364b7e1b9bf28afa8a31490f33731 > src/slave/containerizer/device_manager/device_manager.cpp > fbc532d6e11f8036591c9198219a54c18d345d86 > src/tests/device_manager_tests.cpp b818a5bd9a7427820977bbe05e29eceeb111d653 > > > Diff: https://reviews.apache.org/r/75137/diff/1/ > > > Testing > ------- > > device manager tests pass > > > Thanks, > > Jason Zhou > >
