----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75135/#review226761 -----------------------------------------------------------
Ship it! src/slave/containerizer/device_manager/device_manager.cpp Lines 48-67 (original), 48-65 (patched) <https://reviews.apache.org/r/75135/#comment315037> nit: indentation is off here - Benjamin Mahler On Aug. 1, 2024, 9:10 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75135/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2024, 9:10 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, we only allow normal Entry instances for checking whether a > device access would be allowed for a cgroup. > > We want to also allow NonWildcardEntry instances to do this as well. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.hpp > c1bf3c35d9a358ce367709be1b4c3030a2b8e41a > src/slave/containerizer/device_manager/device_manager.cpp > c255880aa789dc469a3aa29ef7f40decbd5b8389 > > > Diff: https://reviews.apache.org/r/75135/diff/1/ > > > Testing > ------- > > Existing Cgroups2 and DeviceManager tests pass > > > Thanks, > > Jason Zhou > >
