> On July 31, 2024, 8:04 p.m., Benjamin Mahler wrote: > > Ship It!
will add the needed include for this - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75128/#review226747 ----------------------------------------------------------- On July 30, 2024, 3:38 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75128/ > ----------------------------------------------------------- > > (Updated July 30, 2024, 3:38 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, reviewbot is failing from a 'control reaches end of non-void > function' error due to a switch case inside a lambda in the device > manager code. We use an UNREACHABLE macro to stop this error. > > > Diffs > ----- > > src/slave/containerizer/device_manager/device_manager.cpp > 9c3e6c00cedff5aeb4e3726adb002a29517b254f > > > Diff: https://reviews.apache.org/r/75128/diff/2/ > > > Testing > ------- > > Existing DeviceManager and CGROUPS2 tests pass > > > Thanks, > > Jason Zhou > >
