----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75099/#review226723 -----------------------------------------------------------
Ship it! src/linux/cgroups2.cpp Lines 1502-1516 (patched) <https://reviews.apache.org/r/75099/#comment315002> this could just use the selector stringify? - Benjamin Mahler On July 26, 2024, 6:04 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75099/ > ----------------------------------------------------------- > > (Updated July 26, 2024, 6:04 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently we assume that a device state is normalized before using it > for generating ebpf files. However, we have not been enforcing these > constraints. > > We add a helper to check if a device state is normalized so that we can > enforce these constraints. > > An allow or deny list is 'normalized' iff everything below are true: > 1. No Entry can have no accesses specified > 2. No two entries on the same list can have the same type, major & minor > numbers. > 3. No two entries on the same list can be encompassed by the other > entry. > > > Diffs > ----- > > src/linux/cgroups2.hpp accaebdaddc85acdd96b87161ea441c77b025099 > src/linux/cgroups2.cpp ac46782614f6b3b6cb6f2f685492df8364cb73a3 > src/tests/containerizer/cgroups2_tests.cpp > 39f17460c8911244ba28ab052281785dd6235240 > > > Diff: https://reviews.apache.org/r/75099/diff/7/ > > > Testing > ------- > > Added tests for normalized(). Tests passed. > > > Thanks, > > Jason Zhou > >
