----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75056/#review226569 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On June 18, 2024, 8:06 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75056/ > ----------------------------------------------------------- > > (Updated June 18, 2024, 8:06 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > We have noticed that our code does not treat the setMAC bool return value > differently based on whether its true or false. As such, we are changing the > return type to return Nothing so that we either return Error or Nothing, > rather than Error or True or False. As a consequence of this we are also > removing the special case of returning False but not Error when we get ENODEV > from ioctl > > > Diffs > ----- > > src/linux/routing/link/link.hpp 35639afa49e083bb9364fe88a95831e9c711563e > src/linux/routing/link/link.cpp bff172dea63f77a2c7bafd7e3fbee5dca1dfbd51 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 1fd2e226c64897032a8fd61807b619d5813b8737 > src/tests/containerizer/routing_tests.cpp > a030668cb61220629e2df17a793b2d1a4fa0cd80 > > > Diff: https://reviews.apache.org/r/75056/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
