> On Feb. 27, 2024, 4:58 p.m., Benjamin Mahler wrote: > > src/linux/cgroups2.hpp > > Lines 32 (patched) > > <https://reviews.apache.org/r/74872/diff/2/?file=2285447#file2285447line32> > > > > which provided options? there are none getting provided here by the > > caller?
You can provide a set of options when mounting the cgroup2 file system: https://docs.kernel.org/admin-guide/cgroup-v2.html#mounting We currently don't provide a way to pass in any of these options (as they don't exist for cgroups v1), so there are no parameters. I'll update the comment to remove that note about options. - Devin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74872/#review226250 ----------------------------------------------------------- On Feb. 27, 2024, 7:16 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74872/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2024, 7:16 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Introduces: > - `cgroups2::mount()`: Mount the cgroup2 hierarchy. > - `cgroups2::mounted()`: Check if the cgroup2 hierarchy is mounted. > - `cgroups2::mounted_at_root()`: Check if the cgroup2 hierarchy is mounted > at /sys/fs/cgroup. > - `cgroups2::unmount()`: Unmount the cgroup2 hierarchy from /sys/fs/cgroup. > > The root mount point for the cgroup2 file system is hard-coded to be > /sys/fs/cgroup, > which is the default mount point on most systems. > > > Diffs > ----- > > src/linux/cgroups2.hpp 833960d301335541f0bb7ad5c0e05e7222d7bc06 > src/linux/cgroups2.cpp baa13557e31234281da9a40526b45df0444061d4 > > > Diff: https://reviews.apache.org/r/74872/diff/3/ > > > Testing > ------- > > > Thanks, > > Devin Leamy > >
