----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74871/#review226252 -----------------------------------------------------------
src/tests/environment.cpp Lines 232 (patched) <https://reviews.apache.org/r/74871/#comment314495> nit: remove the extra newline here? src/tests/environment.cpp Lines 233-245 (patched) <https://reviews.apache.org/r/74871/#comment314496> hm.. if `__linux__` this is always returning false..? - Benjamin Mahler On Feb. 27, 2024, 5:31 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74871/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2024, 5:31 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > - Introduces cgroups2_tests.cpp which will hold the cgroups2 tests. > - Introduces Cgroups2Filter that will enable cgroups2 tests only if > cgroups2 is enabled on the system and the user is "root". > - Adds a test that checks that cgroups2 is enabled on the testing host. > > > Diffs > ----- > > src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a > src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a > src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION > src/tests/environment.cpp 737c2d916bed0449536dc754249d1b7708aeb681 > > > Diff: https://reviews.apache.org/r/74871/diff/6/ > > > Testing > ------- > > make -j128 check > > > Thanks, > > Devin Leamy > >
