> On Feb. 20, 2024, 4:08 a.m., Benjamin Mahler wrote: > > src/tests/containerizer/cgroups2_tests.cpp > > Lines 17-22 (patched) > > <https://reviews.apache.org/r/74871/diff/1/?file=2285171#file2285171line17> > > > > doesn't look like these includes are needed yet? let's add them only > > when we need them (as a general rule) > > Devin Leamy wrote: > Incidentally <stout/tests/utils.hpp> imports <process/gtest.hpp> and > <stout/gtest.hpp> which are used, so we only need that one :+1:.
Correction: <stout/tests/utils.hpp> imports <stout/gtest.hpp> and <gtest/gtest.h>. <process/gtest.hpp> is unused. - Devin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74871/#review226222 ----------------------------------------------------------- On Feb. 26, 2024, 8:52 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74871/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2024, 8:52 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Introduces cgroups2_tests.cpp which will hold the cgroups2 tests. > Adds a test that checks that cgroups2 is enabled on the testing host. > > > Diffs > ----- > > src/Makefile.am 03aa881e84cf19e95f573ad9d1df3f08a033ef3a > src/tests/CMakeLists.txt 6beb74e382acbda5bca816709312b00785673c4a > src/tests/containerizer/cgroups2_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/74871/diff/4/ > > > Testing > ------- > > make -j128 check > > > Thanks, > > Devin Leamy > >
