----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74870/#review226221 -----------------------------------------------------------
src/linux/cgroups2.hpp Lines 24-25 (patched) <https://reviews.apache.org/r/74870/#comment314460> can you move this to the cpp file? src/linux/cgroups2.cpp Lines 24 (patched) <https://reviews.apache.org/r/74870/#comment314463> no `<string>` include needed here? ditto for the using statement below (although if you move the constant from the header into the .cpp then you'll still need this include) src/linux/cgroups2.cpp Lines 29-32 (patched) <https://reviews.apache.org/r/74870/#comment314461> these files are only relevant to the linux part of the build, so you should be able to just assume linux here and remove the ifdef. (As an aside, this #ifdef isn't ideal since in the case that it matches, it will generate unreachable code after the first return, which can often annoy code analysis tools that check for unreachable code, like you've seen from the tidy emails). src/linux/cgroups2.cpp Lines 34 (patched) <https://reviews.apache.org/r/74870/#comment314462> you could use `*supported` instead of .get(), which seems a bit more readable (we didn't have the star operator when the cgroups v1 code was added) - Benjamin Mahler On Feb. 12, 2024, 5 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74870/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2024, 5 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Introduces the cgroups2 namespace and enabled() function to check if > cgroups2 is supported by the host. To be supported: > 1. The cgroup2 file system type must be supported. > 2. The host must be a linux machine. > > > Diffs > ----- > > src/linux/cgroups2.hpp PRE-CREATION > src/linux/cgroups2.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/74870/diff/1/ > > > Testing > ------- > > > Thanks, > > Devin Leamy > >
