cf-natali commented on code in PR #464:
URL: https://github.com/apache/mesos/pull/464#discussion_r1455431207
##########
src/slave/containerizer/mesos/isolators/xfs/disk.cpp:
##########
@@ -223,14 +224,16 @@ XfsDiskIsolatorProcess::XfsDiskIsolatorProcess(
xfs::QuotaPolicy _quotaPolicy,
const std::string& _workDir,
const IntervalSet<prid_t>& projectIds,
- Duration _projectWatchInterval)
+ Duration _projectWatchInterval,
+ const Bytes& _quotaHeadroom)
Review Comment:
Any reason to pass it by const reference instead of value?
I'd assume `Bytes`must be at most a word or two, and seems to be passed by
value elsewhere.
##########
src/slave/flags.hpp:
##########
@@ -203,6 +203,8 @@ class Flags : public virtual logging::Flags
#if ENABLE_XFS_DISK_ISOLATOR
std::string xfs_project_range;
bool xfs_kill_containers;
+ bool xfs_enable_quotas;
Review Comment:
I'm probably missing something but I can't see anything using
`xfs_enable_quotas`?
##########
src/tests/containerizer/xfs_quota_tests.cpp:
##########
@@ -892,6 +892,94 @@ TEST_F(ROOT_XFS_QuotaTest, VolumeUsageExceedsQuotaWithKill)
}
+// Verify that a task that tries to consme more disk space than it has
requested
Review Comment:
Typo: `consme`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
