cf-natali commented on a change in pull request #398:
URL: https://github.com/apache/mesos/pull/398#discussion_r661748940



##########
File path: support/packaging/common/mesos-slave.service
##########
@@ -11,6 +11,7 @@ RestartSec=20
 LimitNOFILE=16384
 CPUAccounting=true
 MemoryAccounting=true
+Delegate=yes

Review comment:
       Maybe `Delegate=true` for consistency with the others?

##########
File path: docs/configuration/agent.md
##########
@@ -1854,5 +1854,33 @@ quotas for container sandbox directories. Valid project 
IDs range from
 1 to max(uint32). (default `[5000-10000]`)
 </td>
 </tr>
+</table>
+
+## Systemd Integration
+
+<table class="table table-striped">
+  <thead>
+    <tr>
+      <th width="30%">
+        Flag
+      </th>
+      <th>
+        Explanation
+      </th>
+    </tr>
+  </thead>
 
+  <tr id="systemd_delegate">
+    <td>
+      Delegate=yes
+    </td>
+    <td>
+      To prevent systemd from manipulating cgroups managed by the agent, it's 
recommended to add 'Delegate' under 'Service'.
+      Example:
+      <pre><code>
+        [Service]
+        Delegate=yes

Review comment:
       And here.

##########
File path: docs/configuration/agent.md
##########
@@ -1854,5 +1854,33 @@ quotas for container sandbox directories. Valid project 
IDs range from
 1 to max(uint32). (default `[5000-10000]`)
 </td>
 </tr>
+</table>
+
+## Systemd Integration
+
+<table class="table table-striped">
+  <thead>
+    <tr>
+      <th width="30%">
+        Flag
+      </th>
+      <th>
+        Explanation
+      </th>
+    </tr>
+  </thead>
 
+  <tr id="systemd_delegate">
+    <td>
+      Delegate=yes

Review comment:
       Same thing here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to