cf-natali commented on pull request #388: URL: https://github.com/apache/mesos/pull/388#issuecomment-864587247
> > Which means that the task killer can be interrupted after it's frozen the cgroup, but before killing the tasks and thawing. > > @cf-natali I am a bit confused about this, if the cgroup is frozen, then I think we should see a log message like `Successfully froze cgroup ...`, right? But in the logs you pasted (see below), I do not see such message, it just tried to thaw the cgroup even the cgroup was not frozen. I am not sure why it can happen. > > ``` > I0516 23:58:42.638830 466897 linux_launcher.cpp:606] Destroying cgroup '/sys/fs/cgroup/freezer/mesos_test_98d2814b-03ad-4c14-a3f9-832ab688e386/3139257f-4e7a-4828-9af4-75c867846558' > I0516 23:58:42.639083 466898 composing.cpp:343] Finished recovering all containerizers > I0516 23:58:42.639549 466898 cgroups.cpp:2934] Freezing cgroup /sys/fs/cgroup/freezer/mesos_test_98d2814b-03ad-4c14-a3f9-832ab688e386/3139257f-4e7a-4828-9af4-75c867846558 > I0516 23:58:42.714794 466899 cgroups.cpp:2952] Thawing cgroup /sys/fs/cgroup/freezer/mesos_test_98d2814b-03ad-4c14-a3f9-832ab688e386/3139257f-4e7a-4828-9af4-75c867846558 > ``` It happens in case of freeze timeout: https://github.com/apache/mesos/blob/master/src/linux/cgroups.cpp#L1423 The freeze is discarded, then it calls `kill` - which doesn't log anything - then it calls `thaw`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
