qianzhangxa commented on pull request #391:
URL: https://github.com/apache/mesos/pull/391#issuecomment-854755987
> Yes this example wouldn't work anyway but that's because it doesn't
specify the cgroup, whereas the actual code does (
Aha, I see `perf::sample` will be a no-op if no cgroup is specified:
```
Future<hashmap<string, mesos::PerfStatistics>> sample(
const set<string>& events,
const set<string>& cgroups,
const Duration& duration)
{
// Is this a no-op?
if (cgroups.empty()) {
return hashmap<string, mesos::PerfStatistics>();
}
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
