cf-natali commented on pull request #384:
URL: https://github.com/apache/mesos/pull/384#issuecomment-850890927
Ah and by the way, here's how I tested it:
`compat` format - until 2.32/2.31:
```
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c compat
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh
--gtest_filter=*Ld* 2>&1 | tail -n13
[----------] 3 tests from Ldd
[ RUN ] Ldd.BinSh
[ OK ] Ldd.BinSh (2 ms)
[ RUN ] Ldd.EmptyCache
[ OK ] Ldd.EmptyCache (0 ms)
[ RUN ] Ldd.MissingFile
[ OK ] Ldd.MissingFile (1 ms)
[----------] 3 tests from Ldd (3 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (548 ms total)
[ PASSED ] 4 tests.
```
`new` format - supported by this change:
```
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c new
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh
--gtest_filter=*Ld* 2>&1 | tail -n13
[----------] 3 tests from Ldd
[ RUN ] Ldd.BinSh
[ OK ] Ldd.BinSh (3 ms)
[ RUN ] Ldd.EmptyCache
[ OK ] Ldd.EmptyCache (0 ms)
[ RUN ] Ldd.MissingFile
[ OK ] Ldd.MissingFile (1 ms)
[----------] 3 tests from Ldd (4 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (550 ms total)
[ PASSED ] 4 tests.
```
`old` format - never supported - as a sanity check:
```
root@thinkpad:/home/cf/src/mesos/build# ldconfig -c old
root@thinkpad:/home/cf/src/mesos/build# ./bin/mesos-tests.sh
--gtest_filter=*Ld* 2>&1 | tail -n13
cache: Invalid format
[ FAILED ] Ldd.MissingFile (0 ms)
[----------] 3 tests from Ldd (1 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 2 test cases ran. (7 ms total)
[ PASSED ] 1 test.
[ FAILED ] 3 tests, listed below:
[ FAILED ] LdcacheTest.Parse
[ FAILED ] Ldd.BinSh
[ FAILED ] Ldd.MissingFile
3 FAILED TESTS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
