andreaspeters commented on a change in pull request #383:
URL: https://github.com/apache/mesos/pull/383#discussion_r624726591



##########
File path: src/python/cli_new/lib/cli/http.py
##########
@@ -64,7 +73,7 @@ def get_json(addr, endpoint, condition=None, timeout=5, 
query=None):
         data = None
 
         try:
-            data = read_endpoint(addr, endpoint, query)
+            data = read_endpoint(addr, endpoint, config, query)
         except Exception as exception:

Review comment:
       Well, good that you speak it out. The loop also bother me. So I removed 
it and add a timeout into the read_endpoint function. :-) Hope it looks good 
now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to