----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72845/#review222019 -----------------------------------------------------------
Fix it, then Ship it! Looks almost good to go! Found two locations where more clarity would IMO be beneficial, and also a couple of very minor typo-like issues. docs/isolators/csi-volume.md Lines 51 (patched) <https://reviews.apache.org/r/72845/#comment311092> s/mount onto/mount them onto/? docs/isolators/csi-volume.md Lines 82 (patched) <https://reviews.apache.org/r/72845/#comment311093> Maybe more explicit: s/two flags/the `isolation` and `csi_plugin_config_dir` flags/ ? The values of `--master` and `--work_dir` are irrelevant for CSI configuration despite being needed to launch the agent, right? docs/isolators/csi-volume.md Lines 255-256 (patched) <https://reviews.apache.org/r/72845/#comment311094> Hmmm... this place is hard to grasp for a person not closely familiar with the CSI External Volumes. Shouldn't that be s/of one CSI plugin configuration file **under** the directory/of one **of the** CSI plugin configuration file**s** **in** the directory/? Not sure I'm fully getting the intended meaning; please check that what I suggest is what you actually intended. docs/isolators/csi-volume.md Lines 271-272 (patched) <https://reviews.apache.org/r/72845/#comment311095> s/a absolute/an absolute/ - Andrei Sekretenko On Oct. 8, 2020, 9:57 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72845/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2020, 9:57 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10157 > https://issues.apache.org/jira/browse/MESOS-10157 > > > Repository: mesos > > > Description > ------- > > Added doc for the `volume/csi` isolator. > > > Diffs > ----- > > docs/isolators/csi-volume.md PRE-CREATION > docs/mesos-containerizer.md 3231cb93481102dfc26a718918566e61b57e3617 > > > Diff: https://reviews.apache.org/r/72845/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
