----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72806/#review221801 -----------------------------------------------------------
src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 1462 (patched) <https://reviews.apache.org/r/72806/#comment310883> Do we need to do this for the other 2 tests? src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 1567-1568 (patched) <https://reviews.apache.org/r/72806/#comment310884> This comments seems not correct. src/tests/containerizer/volume_csi_isolator_tests.cpp Lines 1676-1689 (patched) <https://reviews.apache.org/r/72806/#comment310886> Could you please elaborate a bit on why we need to publish the volume here? I think during recovery volume manager will publish the volume internally, right? And why does `targetPath` not exist when publishing volume succeeds? - Qian Zhang On Sept. 4, 2020, 9:25 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72806/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2020, 9:25 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added tests for 'volume/csi' isolator recovery. > > > Diffs > ----- > > src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72806/diff/7/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"` > > > Thanks, > > Greg Mann > >
