----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72829/#review221768 -----------------------------------------------------------
Patch looks great! Reviews applied: [72829] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Sept. 1, 2020, 1:30 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72829/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2020, 1:30 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10153 > https://issues.apache.org/jira/browse/MESOS-10153 > > > Repository: mesos > > > Description > ------- > > The `volume/csi` isolator needs to checkpoint CSI volume state under > work dir rather than runtime dir to be consistent with what volume > manager does. Otherwise after agent host is rebooted, volume manager > may publish some volumes during recovery, and those volumes will never > get chance to be unpublished since the `volume/csi` isolator does not > know those volumes at all (the contents in runtime dir will be gone > after reboot). > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > d5d8835f00798884bcf46f728470ee18868b405c > src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp > 5b4a4eeed0e85a5bed90056638414acf3a9e7ab5 > > > Diff: https://reviews.apache.org/r/72829/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
