----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72825/#review221762 -----------------------------------------------------------
Ship it! src/tests/master/update_framework_tests.cpp Lines 460 (patched) <https://reviews.apache.org/r/72825/#comment310819> should probably consistently stick with s/slave/agent/ in these comments - Benjamin Mahler On Aug. 31, 2020, 6:52 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72825/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2020, 6:52 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10166 > https://issues.apache.org/jira/browse/MESOS-10166 > > > Repository: mesos > > > Description > ------- > > This test verifies that calling UPDATE_FRAMEWORK with no changes in > `FrameworkInfo` (i.e. to change suppressed roles or offer constraints) > results in no API event FRAMEWORK_UPDATED sent to the subscribers and > no `UpdatedFrameworkMessage` broadcast to the agents. > > > Diffs > ----- > > src/tests/master/update_framework_tests.cpp > 6346a4eaf2b6c70d1a7d5f32706e781436d36521 > > > Diff: https://reviews.apache.org/r/72825/diff/1/ > > > Testing > ------- > > `src/mesos-tests --gtest_filter='UpdateFrameworkTest.NoRedundantUpdates' > --gtest_repeat=300` > > > Thanks, > > Andrei Sekretenko > >
