----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72804/#review221755 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp Line 66 (original), 66 (patched) <https://reviews.apache.org/r/72804/#comment310810> I'd suggest changing the commit message now that the flag has been removed. Perhaps something like: "Enabled CSI volume access for non-root users." src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp Lines 470-471 (patched) <https://reviews.apache.org/r/72804/#comment310809> Nit: indented too far. - Greg Mann On Aug. 30, 2020, 1:36 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72804/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2020, 1:36 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10153 > https://issues.apache.org/jira/browse/MESOS-10153 > > > Repository: mesos > > > Description > ------- > > Supported chown CSI volumes in the `volume/csi` isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > 373b629a984b6d7f207bc65899e32d5f023685ee > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > 02ef1f215eeb0e6436d42146b922d8a48e023607 > > > Diff: https://reviews.apache.org/r/72804/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
