> On Aug. 26, 2020, 6:57 a.m., Qian Zhang wrote: > > src/tests/mesos.hpp > > Lines 2097 (patched) > > <https://reviews.apache.org/r/72805/diff/1/?file=2238772#file2238772line2097> > > > > Do we need another `createVolumeHostPath` in the `internal` namespace > > at line 1804?
We could add it if we want one for the v0 message type. I didn't add it here because I don't need it yet. Do you think I should add it now? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72805/#review221713 ----------------------------------------------------------- On Aug. 26, 2020, 5:50 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72805/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2020, 5:50 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added a test helper for CSI volumes. > > > Diffs > ----- > > src/tests/mesos.hpp 8f89d7ca5642a475ecbc176d8bba277a6774a8a1 > > > Diff: https://reviews.apache.org/r/72805/diff/1/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > >
