> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote: > > Hm.. is it possible to have a simpler patch that avoids the factory and > > instead passes the flags through the creation path? > > Andrei Sekretenko wrote: > This is possible; however, I would argue that putting limits on RE2 is > rather deep implemenation detail which should not pollute the **public > allocator interface**. > > Given this, and also the need for caching, I'm not sure that passing the > flags through creation path and removing them right after that makes a lot of > sense.
Realized two things: - that I will end up refactoring the factory when adding caching if I leave the factory like this - that there is no need to have the definiotion of the filter options in the public allocator interface; they can be just forward-declared. Removed the factory for now. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72786/#review221697 ----------------------------------------------------------- On Aug. 26, 2020, 12:23 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72786/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2020, 12:23 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10173 > https://issues.apache.org/jira/browse/MESOS-10173 > > > Repository: mesos > > > Description > ------- > > Implemented regex-based offer constraints. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 05d0e9c46485c3048a65d46747d56e715883a0b3 > src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b > src/master/allocator/mesos/offer_constraints_filter.hpp PRE-CREATION > src/master/allocator/mesos/offer_constraints_filter.cpp > d724fd0a9832feea26f6db1a498b6bdee83ffff0 > src/master/constants.hpp c384b6878193a4b6bb09294d8b14757906595c1b > src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 > src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a > src/master/master.hpp e478f805069813532011f2a1991ab1f847080516 > src/master/master.cpp 4428985902512eea1c97205f04a4fed6c16d494e > src/tests/master/offer_constraints_filter_tests.cpp > 84a1e917a52d0b98f979e454c2b982c6402b0176 > > > Diff: https://reviews.apache.org/r/72786/diff/7/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
