-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72745/
-----------------------------------------------------------
(Updated Aug. 20, 2020, 9:09 a.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10172
https://issues.apache.org/jira/browse/MESOS-10172
Repository: mesos
Description
-------
This patch adds protobuf messages for setting offer constraints
on equality/non-equality of agent's (pseudo)attribute to a specified
string.
Both added contsraint predicates will evaluate to `true` when the
attribute is not TEXT. This way, schedulers will still perform all
filtration based on non-TEXT attributes on their own, which helps to
avoid subtle integration bugs caused by discrepancies in Scalar/Ranges
comparison between Mesos and the scheduler.
Given that schedulers seem to rarely put constraints on Scalar/Ranges
attributes in the real world, this should not prevent them from
obtaining performance benefits by setting offer constraints.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto
6e1639a9baf017fa87b274daeedc821389216ddc
include/mesos/v1/scheduler/scheduler.proto
eb5fdeb984b28403bd8281742bd0a5f2053863e3
Diff: https://reviews.apache.org/r/72745/diff/4/
Changes: https://reviews.apache.org/r/72745/diff/3-4/
Testing
-------
Thanks,
Andrei Sekretenko