----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221632 -----------------------------------------------------------
src/slave/slave.cpp Lines 1747 (patched) <https://reviews.apache.org/r/72761/#comment310702> As we discussed in https://reviews.apache.org/r/72759/#comment310644 , this should be `csiServer->start(info.id())` because we need to expose agent ID to managed CSI plugin. Ditto for the code in `Slave::reregistered`. And `Slave::reregistered` can be called multiple times when agent is running, so I think we need this logic https://github.com/apache/mesos/blob/1.10.0/src/resource_provider/daemon.cpp#L165:L176 in `CSIServer::start()` as well rather than always generating auth token every time when `CSIServer::start()` is called. WDYT? - Qian Zhang On Aug. 18, 2020, 1:13 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72761/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2020, 1:13 p.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > This patch adds a CSI server to the Mesos agent in both > the agent binary and in tests. > > > Diffs > ----- > > src/local/local.cpp 895057027165609c792089cd336988b65a3b305d > src/slave/main.cpp 0aa2cc9d254d0b74485a0584b9f55c2266f29367 > src/slave/slave.hpp 2cf45c616d5c50508bc5cd77096b0fef86542b1d > src/slave/slave.cpp c828d99ca9909b904767cc9ea5671b462714f547 > src/tests/cluster.hpp 415a60f5fd4881bca329ffd718f58d676653a17d > src/tests/cluster.cpp ab4cea49eb3e8cf18d320fbb30beaa3c454a08b0 > src/tests/mesos.hpp 0ad0999fba185539c90b053bda43be001da26253 > src/tests/mesos.cpp d6933a60c55802e6f9e89242608fbfad7631faed > src/tests/mock_slave.hpp 58daefa4459eaf15c2394f14db9f94527984b2b8 > src/tests/mock_slave.cpp fa2a0f5c8dadeb8aea87815741bc4fe071d5fbe0 > > > Diff: https://reviews.apache.org/r/72761/diff/3/ > > > Testing > ------- > > Testing details at the end of this chain. > > > Thanks, > > Greg Mann > >
