> On Aug. 18, 2020, 6:36 p.m., Benjamin Mahler wrote: > > Great to have unit tests for this! Mainly left a suggestion about using a > > JSON approach to build the protobuf. > > > > Do we want to add another test here for attributes with multiple entries? > > (i.e. showing that we only look at the first entry)
The test for multiple attributes is in https://reviews.apache.org/r/72776, after the equality constraints are implemented; I don't see how to add such a test without a constraint on the value. JSON looks like a good idea, will try that. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/#review221625 ----------------------------------------------------------- On Aug. 14, 2020, 4:59 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72742/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:59 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > Added basic tests for the `OfferConstraintsFilter`. > > > Diffs > ----- > > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/tests/CMakeLists.txt cf579f8d6e5176e0d4eadabcbadcbb99aa6c737e > src/tests/master/offer_constraints_filter_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72742/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
